Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tuftool dockerfile #710

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Conversation

stockholmux
Copy link
Contributor

Issue #, if available:

n/a

Description of changes:

This PR adds a very simple Dockerfile for tuftool

This solves a problem for Bottlerocket users who have been challenged to download all the dependencies for tuftool just to get an image. Additionally, this potentially avoids the need to create a cross compiled binary (see #662)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea to me. I suspect you have heard from users that they don't like installing Rust to use tuftool? I think we do want to provide binary releases in the future, but this is an easy fix for now.

I need to make sure this works on Linux.

tuftool/README.md Outdated Show resolved Hide resolved
tuftool/README.md Outdated Show resolved Hide resolved
stockholmux and others added 2 commits November 8, 2023 12:30
Co-authored-by: Matthew James Briggs <[email protected]>
Co-authored-by: Matthew James Briggs <[email protected]>
@stockholmux
Copy link
Contributor Author

stockholmux commented Nov 8, 2023

@webern That's right - users don't want the Rust tool chain in every situation. A binary would be more elegant but it's a lot more work and I'd like to give folks a way to use tuftool ASAP.

tuftool/Dockerfile Outdated Show resolved Hide resolved
@cbgbt cbgbt merged commit 36633fe into awslabs:develop Nov 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants