Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: typescript annotation for server #313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: typescript annotation for server #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/http-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export class HttpServer {
* @param {string} [host] Host name.
* @returns {Promise<void>} A promise that resolves when the server has been started.
*/
async start(port?: number, host?: string): Promise<Server> {
async start(port?: number, host?: string): Promise<void> {
if (this.listening) {
throw new Error('Server has already been started.');
}
Expand Down
3 changes: 1 addition & 2 deletions src/lib/oauth2-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

import { readFileSync } from 'fs';
import { AddressInfo } from 'net';
import { Server } from 'http';

import { HttpServer } from './http-server';
import { OAuth2Issuer } from './oauth2-issuer';
Expand Down Expand Up @@ -106,7 +105,7 @@ export class OAuth2Server extends HttpServer {
* @param {string} [host] Host name.
* @returns {Promise<void>} A promise that resolves when the server has been started.
*/
override async start(port?: number, host?: string): Promise<Server> {
override async start(port?: number, host?: string): Promise<void> {
const server = await super.start(port, host);

if (!this.issuer.url) {
Expand Down