-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ampd): add openssl dependency as a vendored dependency to enable arm compilation #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 241 241
Lines 33883 33883
=======================================
Hits 31697 31697
Misses 2186 2186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…rnetwork/axelar-amplifier into fixes/fix-openssl-arm64-deps-build
cgorenflo
reviewed
Sep 19, 2024
This reverts commit 2b2aa47.
…rnetwork/axelar-amplifier into fixes/fix-openssl-arm64-deps-build
cgorenflo
reviewed
Sep 19, 2024
cgorenflo
reviewed
Sep 19, 2024
cgorenflo
reviewed
Sep 19, 2024
cgorenflo
reviewed
Sep 19, 2024
cgorenflo
reviewed
Sep 19, 2024
cgorenflo
reviewed
Sep 19, 2024
cgorenflo
reviewed
Sep 19, 2024
cgorenflo
approved these changes
Sep 19, 2024
cgorenflo
changed the title
chore: add openssl dependency as a vendored dependency
chore(ampd): add openssl dependency as a vendored dependency to enable arm compilation
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
openssl
as avendor
dependency to ensure thearm64
and othertarget
compilation regardless of the underlying running architecture.Explanation:
openssl
library usage requiresopenssl
being installed on the compilation machine that matches thetarget
(in this caseaarch64
). This will cause issues to other users who want to compileamplifier
for othertargets
architectures from a single machine (needs to reinstall and compileopenssl
for eachtarget
separately on their machines).Todos
Steps to Test
Expected Behaviour
Other Notes