Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ampd): add openssl dependency as a vendored dependency to enable arm compilation #630

Merged
merged 19 commits into from
Sep 20, 2024

Conversation

apolikamixitos
Copy link
Contributor

Description

  • Added openssl as a vendor dependency to ensure the arm64 and other target compilation regardless of the underlying running architecture.

Explanation:

openssl library usage requires openssl being installed on the compilation machine that matches the target (in this case aarch64). This will cause issues to other users who want to compile amplifier for other targets architectures from a single machine (needs to reinstall and compile openssl for each target separately on their machines).

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.54%. Comparing base (1983493) to head (f87d5c9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #630   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files         241      241           
  Lines       33883    33883           
=======================================
  Hits        31697    31697           
  Misses       2186     2186           
Flag Coverage Δ
93.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ampd/Cargo.toml Outdated Show resolved Hide resolved
@cgorenflo cgorenflo changed the title chore: add openssl dependency as a vendored dependency chore(ampd): add openssl dependency as a vendored dependency to enable arm compilation Sep 19, 2024
@cgorenflo cgorenflo merged commit 05dbeea into main Sep 20, 2024
8 checks passed
@cgorenflo cgorenflo deleted the fixes/fix-openssl-arm64-deps-build branch September 20, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants