Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra-artifacts uses the full path as the filename #814

Closed
Gankra opened this issue Feb 23, 2024 · 0 comments · Fixed by #1128
Closed

extra-artifacts uses the full path as the filename #814

Gankra opened this issue Feb 23, 2024 · 0 comments · Fixed by #1128
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Gankra
Copy link
Member

Gankra commented Feb 23, 2024

in axodotdev/oranda#667 we had

[[workspace.metadata.dist.extra-artifacts]]
artifacts = ["oranda-css/dist/oranda.css"]
build = ["cargo", "run", "--", "generate-css"]

and this made cargo-dist want to create an artifact named oranda-css/dist/oranda.css, which is, not right.

I worked around this by making it possible to make generate-css write to the top-level dir, but, this is a cargo-dist bug.
@Gankra Gankra added the bug Something isn't working label Feb 23, 2024
@Gankra Gankra added the good first issue Good for newcomers label May 9, 2024
@Gankra Gankra mentioned this issue Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: rework extra_artifacts to properly use paths axodotdev/cargo-dist
1 participant
@Gankra