Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): migrate from null-ls to none-ls #1088

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

Jint-lzxy
Copy link
Collaborator

IMO we can switch to none-ls before we decide on the best alternative to null-ls b/c it's a drop-in replacement for null-ls, and we can continue to receive future bug fixes as well.

IMO we can switch to `none-ls` before we decide on the best alternative
to `null-ls` b/c it's a drop-in replacement for `null-ls`, and we
can continue to receive future bug fixes as well.
@YuCao16
Copy link
Contributor

YuCao16 commented Dec 4, 2023

Can we consider other alternatives like conform.nvim, the advantages of which seem attractive.
#851 (comment)

@Mythos-404
Copy link
Contributor

Mythos-404 commented Dec 4, 2023

conform.nvim provides format_on_save and format_after_save to make it easier to customize the formatting of the save, and to add unsupported formatting programs.

my fork repository configuration can be used as a reference,please forgive me if the code is written badly
conform config
formate config

@ayamir
Copy link
Owner

ayamir commented Dec 5, 2023

I tend to none-ls b/c we have too many stuffs binding with null-ls and none-ls is maintained by community now.

@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented Dec 5, 2023

As @Mythos-404 stated:

After I replaced null-ls with conform.nvim I found that conform.nvim has these advantages over

  1. startup speed improvement
  2. performance improvement when formatting
  3. formatting without breaking code folding
  4. the ability to specify a range of formatting

Could u show us some profile numbers to let we know that's the trade-off?
Or I can do it when I got time.


Tho there might be some attractive side of conform.nvim, as @YuCao16 said, i dont really see it as a replacement to null-ls.nvim. For example, null-ls provides "Code actions", "Hover" and so on to be configured; however, i dont see sth relatable in conform.nvim? (or did i missed it?)
But i do appreciate the comprehensiveness of conform.nvim about formatting.


Continuity of the user experiences is also a big part when planing migrations, users with less experiences will pop up with A LOT OF issues. However, if it worth the pain, i think we'll all embrace the change!

@Mythos-404
Copy link
Contributor

Could u show us some profile numbers to let we know that's the trade-off?

This is my warehouse.

Use none-ls.nvim first, after all, null.nvim has not been maintained for too long.

Migrating null-ls.nvim to conform.nvim requires a lot of code changes, which is not cost-effective at the moment, after all, nvimdots has a mature null-ls.nvim configuration now.

Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge it first.

@ayamir ayamir merged commit 2b43109 into main Dec 5, 2023
4 checks passed
@ayamir ayamir deleted the feat/from-null_ls-to-none_ls branch December 5, 2023 12:27
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Dec 6, 2023
IMO we can switch to `none-ls` before we decide on the best alternative
to `null-ls` b/c it's a drop-in replacement for `null-ls`, and we
can continue to receive future bug fixes as well.
ttbug pushed a commit to ttbug/nvimconf that referenced this pull request Dec 13, 2023
IMO we can switch to `none-ls` before we decide on the best alternative
to `null-ls` b/c it's a drop-in replacement for `null-ls`, and we
can continue to receive future bug fixes as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants