Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Thumbnail in Page/Event/News Editor Too Small + oEmbed Errors #2946

Closed
natebyerley opened this issue Nov 22, 2023 · 2 comments · Fixed by #2949
Closed

Video Thumbnail in Page/Event/News Editor Too Small + oEmbed Errors #2946

natebyerley opened this issue Nov 22, 2023 · 2 comments · Fixed by #2949
Assignees
Labels
2.8.x only To be included in the 2.8 minor release only. bug Something isn't working editor experience Improvements to the editor experience for individuals editing Quickstart websites patch release Issues to be included in the next patch release

Comments

@natebyerley
Copy link

natebyerley commented Nov 22, 2023

Problem/Motivation

Discovered during testing 2.8.1 in test. Testing protocol is to build new page content and try to find issues with CK Editor 5. Looking particularly at differences in how CK Editor works on a Page, vs Event, News, Person.

Describe the bug

Note: All video visibility issues described below are when viewing page editor. Front end displaying correctly in all cases.

When embedding remote video in a Person Bio (or News Article Body or Event Description), the thumbnail for the video is tiny, and remains tiny regardless of the 'size' setting for the video.

On a Page, embedding a remote video - the video is more visible (not tiny) but doesn't change size based on 'size' setting.

Also, getting an error "Could not retrieve the oEmbed resource." when adding a new video, though videos seem to display as expected on front end.

Screenshots below show:

  • View of embedded video on a Page (editor)
  • View of embedded video on News (editor) - which is the same as in Event Description or Person Bio
  • oEmbed errors

To Reproduce

  1. On a site on QS 2.8.1
  2. Embed a 'remote video' within a Person Bio, News Article Body or Event Description.

Note tiny size, that does not adjust if you change the width of the video

Proposed resolution

...

Expected behavior

Seems like a true WYSIWYG editor experience would have video size change with video size setting. So I'm not sure if the Page editor experience of embedding a video is 'expected' or just 'better than' the experience on News/Person/Event.

Screenshots

Screenshot 2023-11-21 at 3 28 59 PM

Screenshot 2023-11-21 at 3 35 57 PM

Screenshot 2023-11-21 at 3 39 07 PM

Screenshot 2023-11-21 at 3 38 03 PM

Desktop (please complete the following information):

  • OS: Mac OS
  • Browser : Safari and Firefox
@danahertzberg
Copy link
Contributor

danahertzberg commented Nov 22, 2023

Created a branch, but have no useful changes committed yet.

Started looking at this https://stackoverflow.com/questions/57320194/ckeditor-5-showing-video-element-but-plain-html-inserted-in-a-div-does-not-show but don't know where to put mediaEmbed setting if that would even be a viable solution.

Looks like CKE4 has this CSS defined.

.az-media.embed-responsive {
    width: 400px;
}

In CKE5, the az-media class is applied, but not defined.

@danahertzberg danahertzberg removed their assignment Nov 22, 2023
@danahertzberg
Copy link
Contributor

Per @joeparsons: Possibly related (at least for the oEmbed error): https://www.drupal.org/project/drupal/issues/3188842

@bberndt-uaz bberndt-uaz self-assigned this Nov 27, 2023
@joeparsons joeparsons added bug Something isn't working editor experience Improvements to the editor experience for individuals editing Quickstart websites labels Nov 27, 2023
@bberndt-uaz bberndt-uaz linked a pull request Nov 27, 2023 that will close this issue
31 tasks
@joeparsons joeparsons added patch release Issues to be included in the next patch release 2.8.x only To be included in the 2.8 minor release only. labels Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8.x only To be included in the 2.8 minor release only. bug Something isn't working editor experience Improvements to the editor experience for individuals editing Quickstart websites patch release Issues to be included in the next patch release
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants