-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Thumbnail in Page/Event/News Editor Too Small + oEmbed Errors #2946
Comments
Created a branch, but have no useful changes committed yet.
Looks like CKE4 has this CSS defined.
In CKE5, the |
Per @joeparsons: Possibly related (at least for the oEmbed error): https://www.drupal.org/project/drupal/issues/3188842 |
Problem/Motivation
Discovered during testing 2.8.1 in test. Testing protocol is to build new page content and try to find issues with CK Editor 5. Looking particularly at differences in how CK Editor works on a Page, vs Event, News, Person.
Describe the bug
Note: All video visibility issues described below are when viewing page editor. Front end displaying correctly in all cases.
When embedding remote video in a Person Bio (or News Article Body or Event Description), the thumbnail for the video is tiny, and remains tiny regardless of the 'size' setting for the video.
On a Page, embedding a remote video - the video is more visible (not tiny) but doesn't change size based on 'size' setting.
Also, getting an error "Could not retrieve the oEmbed resource." when adding a new video, though videos seem to display as expected on front end.
Screenshots below show:
To Reproduce
Note tiny size, that does not adjust if you change the width of the video
Proposed resolution
...
Expected behavior
Seems like a true WYSIWYG editor experience would have video size change with video size setting. So I'm not sure if the Page editor experience of embedding a video is 'expected' or just 'better than' the experience on News/Person/Event.
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: