Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3762: Re-save and re-export all views config in order to capture config drift #3766

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Closes #3762: Re-save and re-export all views config in order to capture config drift #3766

wants to merge 2 commits into from
+744 −568

Conversation

ejsamboy
Copy link
Contributor

Description

Closes: #3762

Re-saved and re-exported the existing Views configurations to resolve configuration drift issues when changes are made to old Views and then exported for a pull request.

How to test

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@ejsamboy ejsamboy requested a review from a team as a code owner October 10, 2024 21:54
@tadean
Copy link
Contributor

tadean commented Oct 11, 2024

It looks like some instances of field_az_metatag and related dependencies may be false positives from having az_seo enabled while exporting. This export should probably take place with az_seo not installed, I think.

There are alternate overridden versions in the az_seo module that are maintained separately for these entities:

core.entity_form_display.node.az_event.default.yml
core.entity_form_display.node.az_flexible_page.default.yml
core.entity_form_display.node.az_news.default.yml
core.entity_form_display.node.az_person.default.yml

Copies of these should probably be generated after the fact, with az_seo enabled.

@danahertzberg
Copy link
Contributor

I propose merging this first 😬 #3610

trackleft
trackleft reviewed Oct 16, 2024
View reviewed changes
.../az_person/config/install/core.entity_view_display.node.az_person.az_row_with_background.yml
Copy link
Member

@trackleft trackleft Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a view config file, remove this from the PR.

trackleft
trackleft reviewed Oct 16, 2024
View reviewed changes
modules/custom/az_news/config/install/core.entity_view_display.node.az_news.az_row.yml
Copy link
Member

@trackleft trackleft Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a view config file, remove this from the PR.

trackleft
trackleft reviewed Oct 16, 2024
View reviewed changes
...loud/config/install/core.entity_view_display.node.az_news.az_marketing_cloud_text_layout.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a view config file, remove this from the PR.

trackleft
trackleft reviewed Oct 16, 2024
View reviewed changes
...loud/config/install/core.entity_view_display.node.az_news.az_marketing_cloud_hero_layout.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a view config file, remove this from the PR.

trackleft
trackleft reviewed Oct 16, 2024
View reviewed changes
...nstall/core.entity_view_display.node.az_news.az_marketing_cloud_70_30_layout_image_right.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a view config file, remove this from the PR.

trackleft
trackleft reviewed Oct 16, 2024
View reviewed changes
...nstall/core.entity_view_display.node.az_news.az_marketing_cloud_50_50_layout_image_right.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a view config file, remove this from the PR.

trackleft
trackleft reviewed Oct 16, 2024
View reviewed changes
...oud/config/install/core.entity_view_display.node.az_news.az_marketing_cloud_50_50_layout.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a view config file, remove this from the PR.

trackleft
trackleft reviewed Oct 16, 2024
View reviewed changes
...oud/config/install/core.entity_view_display.node.az_news.az_marketing_cloud_30_70_layout.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a view config file, remove this from the PR.

trackleft
trackleft reviewed Oct 16, 2024
View reviewed changes
...ud/config/install/core.entity_view_display.node.az_event.az_marketing_cloud_event_layout.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a view config file, remove this from the PR.

trackleft
trackleft reviewed Oct 16, 2024
View reviewed changes
...age/config/install/core.entity_view_display.node.az_flexible_page.az_row_with_background.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a view config file, remove this from the PR.

trackleft
trackleft reviewed Oct 16, 2024
View reviewed changes
modules/custom/az_publication/config/install/views.view.az_publications.yml
@@ -659,7 +659,7 @@ display:
exposed: false
draggable_views_reference: 'az_publications_curate:curation_page'
draggable_views_null_order: before
draggable_views_pass_arguments: true
draggable_views_pass_arguments: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a new issue about this https://www.drupal.org/project/draggableviews/issues/3481312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeparsons joeparsons joeparsons left review comments

@trackleft trackleft trackleft left review comments

@tadean tadean tadean left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@ejsamboy ejsamboy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-save and re-export all views config in order to capture config drift.
5 participants
@ejsamboy @tadean @danahertzberg @joeparsons @trackleft