Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARIA controls title #3792

Open
danahertzberg opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3794
Open

Fix ARIA controls title #3792

danahertzberg opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3794
Assignees

Comments

@danahertzberg
Copy link
Contributor

danahertzberg commented Oct 18, 2024

Problem/Motivation

When scanning the site with Dubbot, this Level A issue arose as seen on https://commencement.arizona.edu/convocations

Describe the bug

In accordions, the aria-controls="" is not referencing the correct ID of the accordion body.

To Reproduce

  1. Add an accordion with title and body
  2. Inspect to see aria-controls="az-accordion-aria-controls--2" on the title's button tag
  3. Inspect to see id="az-accordion--2" on the accordion body div

Proposed resolution

Change the ID associated with accordion titles.

Example: Change aria-controls="az-accordion-aria-controls--2" to aria-controls="az-accordion--2"

https:/az-digital/az_quickstart/blob/main/modules/custom/az_accordion/src/Plugin/Field/FieldFormatter/AZAccordionDefaultFormatter.php#L137

Expected behavior

aria-controls and id should match

Additional context

https://app.dubbot.com/sites/5dc32d02482faf0915d31627/pages/65f43beab48ef57db1f27a1d?tab=accessibility&issueId=aria-valid-attr-value

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-controls

@danahertzberg danahertzberg self-assigned this Oct 18, 2024
@danahertzberg danahertzberg linked a pull request Oct 18, 2024 that will close this issue
32 tasks
@danahertzberg danahertzberg linked a pull request Oct 18, 2024 that will close this issue
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant