Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3113 Standard text format cannot be edited in the UI without removing allowed tags #3114

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

bberndt-uaz
Copy link
Contributor

@bberndt-uaz bberndt-uaz commented Jan 19, 2024

Description

Adds a patch for Drupal core issue 3410100 to revert some updates to CKEditor validation for the source editing "Manually editable HTML tags" field, which is currently preventing the edit form for the Standard text format from being able to be saved.

The patch should be removed once the Drupal core issue is resolved.

Related issues

Closes #3113

How to test

Link to Probo review site: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3114.probo.build

  1. Log in as an Administrator user
  2. Go to Configuration > Text formats and editors > click the Configure button for the Standard text format (/admin/config/content/formats/manage/az_standard).
  3. Make one small change and click the Save configuration button at the bottom.
  4. Confirm that a "The text format Standard has been updated" message is displayed, indicating that the configuration was saved successfully.
  5. Go back to the configuration page to confirm that the change you made was saved.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bberndt-uaz bberndt-uaz added bug Something isn't working blocker 2.9.x only labels Jan 19, 2024
@bberndt-uaz bberndt-uaz self-assigned this Jan 19, 2024
@bberndt-uaz bberndt-uaz marked this pull request as ready for review January 22, 2024 18:48
@bberndt-uaz bberndt-uaz requested a review from a team as a code owner January 22, 2024 18:48
joeparsons
joeparsons previously approved these changes Jan 22, 2024
Copy link
Member

@joeparsons joeparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. I verified that I was able to save the editor config on ProboCI and that the warning message renders as expected.

Nice work!

@joeparsons
Copy link
Member

Someone submitted a patch on d.o. that provides another potential workaround we could consider using: https://www.drupal.org/project/drupal/issues/3410100#comment-15409300

It reverts the recent changes made to the SourceEditingRedundantTagsValidator without disabling it completely.

Copy link
Member

@joeparsons joeparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed I am still able to save the editor config settings on ProboCI with the patch.

@tadean
Copy link
Contributor

tadean commented Jan 24, 2024

- Applying patches for drupal/core
   ...
    https://www.drupal.org/files/issues/2024-01-23/drupal-revert-source-editing-validation-tightening-3410100-38.patch ([10.2 regression] CKEditor 5 breaks when 'Source'/Source editing button is added and 'Manually editable HTML tags' are specified (3410100))

Verified locally that the text format settings can be saved without validation errors with the patch applied.

@joeparsons joeparsons merged commit 5f4796d into main Jan 24, 2024
13 checks passed
@joeparsons joeparsons deleted the issue/3113 branch January 24, 2024 17:19
@trackleft trackleft added the high priority Must get done for this milestone label Jan 24, 2024
@joeparsons joeparsons mentioned this pull request Jan 25, 2024
joeparsons pushed a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9.x only blocker bug Something isn't working high priority Must get done for this milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standard text format cannot be edited in the UI without removing allowed tags
4 participants