Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #3765 Change top-level Quickstart toolbar link to an internal page instead of an external page. #3767

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented Oct 10, 2024

Description

I've updated the link to be an internal route.

We may want to update the bottom of this page https://quickstart.arizona.edu/site-admin/navigating-administration-section

Related issues

Close #3765

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@danahertzberg
Copy link
Contributor

This is lovely. I'm not sure why the Quickstart 2 link doesn't allow me to open it in a new tab though..

Screen recording

@trackleft trackleft changed the title Convert external link to nolink. Close #3765 Convert external link to nolink. Oct 11, 2024
@joeparsons joeparsons added the bug Something isn't working label Oct 11, 2024
@trackleft trackleft changed the title Close #3765 Convert external link to nolink. Close #3765 Link to an internal page instead of an external page. Oct 11, 2024
@danahertzberg
Copy link
Contributor

Can it link to here, please? /admin/config/az-quickstart

@trackleft trackleft marked this pull request as ready for review October 11, 2024 18:14
@trackleft trackleft requested a review from a team as a code owner October 11, 2024 18:14
@trackleft trackleft added editor experience Improvements to the editor experience for individuals editing Quickstart websites patch release Issues to be included in the next patch release usability Improvements to usability of Quickstart components user experience Improvements to user experience labels Oct 11, 2024
Copy link
Contributor

@joshuasosa joshuasosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice change!

Considering where it goes now (/admin/config/az-quickstart), it would be nice if that page included the same links that are within the sub-menu of Quickstart 2.

It already has Settings, so it'd just need:

  • Releases
  • Documentation
  • Analytics Dashboard

Not sure if this PR is a fine place to add that or if a separate issue should be made.

@joeparsons
Copy link
Member

This is a nice change!

Considering where it goes now (/admin/config/az-quickstart), it would be nice if that page included the same links that are within the sub-menu of Quickstart 2.

It already has Settings, so it'd just need:

  • Releases
  • Documentation
  • Analytics Dashboard

Not sure if this PR is a fine place to add that or if a separate issue should be made.

Good idea. Thanks @joshuasosa. @danahertzberg Is going to make a separate issue for that.

@joeparsons joeparsons changed the title Close #3765 Link to an internal page instead of an external page. Close #3765 Change top-level Quickstart toolbar link to an internal page instead of an external page. Oct 14, 2024
@joeparsons joeparsons merged commit 38cec4a into main Oct 14, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3765 branch October 14, 2024 16:22
@danahertzberg
Copy link
Contributor

danahertzberg commented Oct 14, 2024

@joshuasosa This is a great recommendation, thank you! I've created a new ticket for that here.

joeparsons pushed a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor experience Improvements to the editor experience for individuals editing Quickstart websites patch release Issues to be included in the next patch release usability Improvements to usability of Quickstart components user experience Improvements to user experience
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Link in admin UI goes to external site
5 participants