Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish holidays & translation #18

Merged
merged 5 commits into from
Apr 14, 2016
Merged

polish holidays & translation #18

merged 5 commits into from
Apr 14, 2016

Conversation

mpdx
Copy link
Contributor

@mpdx mpdx commented Apr 11, 2016

No description provided.

@stelgenhof
Copy link
Member

Thank you @mpdx ! Let me review the PR. Nice to have Poland added as well :)

@stelgenhof
Copy link
Member

There is a basic test file missing for the country/region itself. It should be called PolandTest.php and needs to contain tests which holidays you are expecting from the provider class. Check the other countries for an example.

@mpdx
Copy link
Contributor Author

mpdx commented Apr 12, 2016

@stelgenhof aye, mate! thanks for the info!

@stelgenhof
Copy link
Member

It seems there is no unit test for Corpus Christi. Can you add that one too?

@stelgenhof stelgenhof added this to the v1.3.0 milestone Apr 13, 2016
@stelgenhof stelgenhof self-assigned this Apr 14, 2016
@stelgenhof stelgenhof merged commit 9e57a5e into azuyalabs:master Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants