Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation for fr_LU and fr_CA #211

Merged
merged 2 commits into from
Mar 15, 2020

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Mar 14, 2020

Update the French translation for Second Christmas Day for Luxembourg and Canada.

Credits to @Arkounay for his insights on this.

Quote from #188 (comment):

I remember we spoke about this at work and picked "Lendemain de Noël" as a translation because the majority of us said that naturally and an app we use translated it as so.

I think the app we use is based from this website, where it's translated as "Lendemain de Noël" for Luxembourg :
https://www.joursferies.fr/pays/luxembourg.php

However, if we check the homepage (https://www.joursferies.fr/) when it comes to France it's indeed translated as Saint-Étienne too there. Since these regions in France are close to Luxembourg, I thought that day had the same name.

So you're right, Saint-Étienne is the proper term in France.
I'm sorry for the mistake!

  • For the fr locale we should definitely translate it as "Saint-Étienne"
  • However for fr_lu I'd change it into "Deuxième jour de Noël" as it seems it's the official term there

I've checked official Luxembourg websites and there it's translated as translated as "Deuxième jour de Noël" :
https://luxembourg.public.lu/fr/vivre/qualite-de-vie/jours-feries-legaux.html
https://itm.public.lu/fr/conditions-travail/conges/jours-feries.html
(I think these two websites are worth more than banquedeluxembourg.com since the public.lu domain is reserved for the government)

@stelgenhof stelgenhof merged commit 32b8c63 into azuyalabs:develop Mar 15, 2020
@stelgenhof stelgenhof added this to the v2.3.0 milestone Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants