Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SouthKorea provider to apply the new substitute holidays changed in June 2021. #255

Merged
merged 13 commits into from
Sep 5, 2021

Conversation

barami
Copy link
Contributor

@barami barami commented Jul 6, 2021

Hi.
The new substitute holidays bill was passed in korea on june 2021.
I have updated SouthKorea provider and added tests for substitute holidays.

  1. All statutory holidays overlaping weekend or other holiday will be substitute at next working day.
  2. The above provisions shall be in force in 2022, but substitute holidays of second half of 2021 shall be applied by the supplementary provision.

https://en.yna.co.kr/view/AEN20210629007500315
http://tbs.seoul.kr/eFm/newsView.do?typ_800=N&idx_800=3441140&seq_800=

@stelgenhof
Copy link
Member

Super! Thanks so much.

@stelgenhof stelgenhof added this to the v2.5.0 milestone Jul 6, 2021
@barami
Copy link
Contributor Author

barami commented Jul 15, 2021

We should postpone merging this pr until complete the selection of substitute holiday.
According to the bill, holidays allowed to substitute is designated by Presidential Decree.
But, The Korean government said it will apply alternative holidays only on some public holidays, not all public holidays on July 15.

@stelgenhof stelgenhof marked this pull request as draft July 17, 2021 13:32
@stelgenhof stelgenhof removed this from the v2.5.0 milestone Aug 6, 2021
@barami barami marked this pull request as ready for review August 10, 2021 05:00
@barami
Copy link
Contributor Author

barami commented Aug 10, 2021

http://www.koreaherald.com/view.php?ud=20210803000365
The revised public holiday presidential decree came into force on August 4.
The new commits change rules for substitution accordingly.

@barami
Copy link
Contributor Author

barami commented Sep 1, 2021

@stelgenhof Static snalysis is always failed for Yasumi/Yasumi.php. Even fork upstream to another repository and run actions, it was failed.
I don't know that how to fix it.

@stelgenhof
Copy link
Member

@barami I am aware of the CI failing. Some issue in the core files causing this. I will have a look.

@stelgenhof
Copy link
Member

@barami I've fixed the issues with the CI. Please update your branch. Thanks!

@stelgenhof stelgenhof added this to the v2.5.0 milestone Sep 1, 2021
@stelgenhof
Copy link
Member

The ChildrensDayTest class seems to be altered with Buddha's Birthday. Is that correct?

@stelgenhof
Copy link
Member

@barami Can you also update the CHANGELOG.md file (on the top) that explains the this PR (in non-technical terms as much as possible). Thanks!

@barami
Copy link
Contributor Author

barami commented Sep 3, 2021

@stelgenhof
Yes. Children's Day and Buddha's birthday often overlap, so it is necessary to test alternative holidays when two holidays overlap.
In addition, National foundation day and Chuseok also sometimes overlap with each other, so I wrote the test.

Also, I will update CHANGELOG.md as you say.

@stelgenhof stelgenhof merged commit 3ef3d02 into azuyalabs:develop Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants