Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add International Womens Day to DE-MV #311

Merged
merged 8 commits into from
Oct 15, 2023
Merged

Conversation

ihmels
Copy link
Contributor

@ihmels ihmels commented Mar 6, 2023

No description provided.

Copy link
Member

@stelgenhof stelgenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the appropriate unit tests for your change? Also, if you have any documentation or reference for this change, that would be great.

@stelgenhof
Copy link
Member

@ihmels Can you add the appropriate unit tests for your change? Also, if you have any documentation or reference for this change, that would be great.

@ihmels
Copy link
Contributor Author

ihmels commented Jul 11, 2023

I have added a test.

The source is https://www.ndr.de/nachrichten/mecklenburg-vorpommern/Frauentag-in-MV-Landtag-beschliesst-neuen-Feiertag,frauentag370.html. However, there is another source on Wikipedia that is already referenced via Germany::getSources().

Where is the best place to put the source?

@ihmels ihmels requested a review from stelgenhof July 11, 2023 07:02
@stelgenhof
Copy link
Member

@ihmels Good point regarding the source. You could override the getSources method while adding the additional link.

@ihmels
Copy link
Contributor Author

ihmels commented Jul 13, 2023

@stelgenhof I've added the source and fixed the namespace in the test. Can you run the workflow again for these changes?

@ihmels
Copy link
Contributor Author

ihmels commented Aug 30, 2023

@stelgenhof Can you approve the workflow again?

@stelgenhof
Copy link
Member

@ihmels Can you check you once more? There are still some errors.

@ihmels
Copy link
Contributor Author

ihmels commented Oct 10, 2023

@ihmels Can you check you once more?

@stelgenhof The error was:

ERROR: InvalidReturnStatement - src/Yasumi/Yasumi.php:245:16 - The inferred type 'array<string, array<array-key, string>|null|string>' does not match the declared return type 'array<string, string>' for Yasumi\Yasumi::getProviders (see https://psalm.dev/128)
       return $providers

This error was not related to my changes, but I fixed it. Can you run tests again?

@stelgenhof
Copy link
Member

@ihmels I've made some fixes on the develop branch that would make your PR error free. Can you rebase your branch? Thanks.

@stelgenhof stelgenhof merged commit 9da5acb into azuyalabs:develop Oct 15, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants