Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require php calendar extension to prevent breaking sites #54

Closed

Conversation

Jarlskov
Copy link

@Jarlskov Jarlskov commented Feb 4, 2017

I've accidentally taken down a production site because the server did not have the calendar extension installed, and I was not aware that I needed it (or that it existed actually).
Since it's a hard dependency for the library to function, that should be more obvious :-)

@stelgenhof
Copy link
Member

@Jarlskov Sorry to hear that your site was taken down because of this :( You are correct that it is not clear that the calendar extension is actually required. If I recall, I wanted to stay away from such dependency but think I ended up using it anyway.

Your PR is good in that it will enforce the use of the calendar extension. Now that I am thinking of it, I think I want to provide an implementation of the easter_days function within Yasumi that would replace the need for the extension after all.

@stelgenhof stelgenhof added the bug label Feb 4, 2017
@stelgenhof stelgenhof self-assigned this Feb 4, 2017
@stelgenhof stelgenhof added this to the v1.6.1 milestone Feb 4, 2017
@Jarlskov
Copy link
Author

Jarlskov commented Feb 4, 2017

No worries, that's our own fault. We were able to roll back quickly, and it showed some flaws in our test procedures :-)

I'm not sure why you would want to maintain existing functionality, but that's up to you how you want to solve it, but I think it would make sense to add something like this until you get around to implementing the easter_days functions. I don't believe this PR should cause any BC breaks.

@stelgenhof
Copy link
Member

Ah yes, I see. Merging this PR will indeed not cause any BC issues. Implementing a easter_days function as part of Yasumi isn't that difficult and planning on releasing it pretty soon :)

@stelgenhof
Copy link
Member

Fallback easter_days calculation implemented in case the PHP calendar extension is not loaded. (See PR #55)

@stelgenhof stelgenhof closed this Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants