Add new exceptions in Yasumi. #95
Conversation
|
@stelgenhof you prefer me in author or you ? |
|
@qneyrat You can put yourself as an author in the Class comments section :) and leave the file comments as is. |
|
To catch specific exception and not invalidArgument is so generic. |
|
@stelgenhof are you ready to merge ? |
|
@qneyrat I believe there are some unanswered questions in the review of your PR. |
|
@stelgenhof which ones ? |
|
@rmasclef There is a small conversation regarding the use of the To me it looks like it is not concluded :) |
|
@stelgenhof indeed, I agree with that one 👍 |
| @@ -7,7 +7,7 @@ | |||
| * For the full copyright and license information, please view the LICENSE | |||
| * file that was distributed with this source code. | |||
| * | |||
| * @author Sacha Telgenhof <stelgenhof@gmail.com> | |||
| * @author Quentin Neyrat <quentin.neyrat@gmail.com> | |||
There was a problem hiding this comment.
Can you leave my name here unchanged? You can add yours in the comment above the class definition like this:
/**
* Class InvalidYearException.
*
* @author Quentin Neyrat <[email protected]>
*/
class InvalidYearException extends InvalidArgumentException implements Exception
{
|
@qneyrat Can you please review your PR as there are some unanswered questions? If I don't get any feedback by the end of next week, I will close this PR. |
|
it's ready for me :) |
|
Hello, I don't have time to improve this PR for so that it is ready to merge. Anyone like to improve code? Else, I can close that. |
|
@qneyrat No worries. I will pick up from here. Anyways, thanks for the contribution! |
No description provided.