Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change: Rename var.tags to var.default_tags #44

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

jansiwy
Copy link
Member

@jansiwy jansiwy commented Sep 23, 2024

This change is done to make it more clear, that tags specified via this attribute will be assigned to all AWS resources created by this module.

Also drop this attribute from the usage example in the README.md, as this attribute is rather for edge cases, as default tags typically specified via the default_tags block of the AWS provider.

@jansiwy jansiwy requested a review from a team September 23, 2024 10:52
@jansiwy jansiwy self-assigned this Sep 23, 2024
@jansiwy jansiwy merged commit dacbd4e into main Sep 23, 2024
5 checks passed
@jansiwy jansiwy deleted the default-tags branch September 23, 2024 11:08
@jansiwy jansiwy added the major label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants