fix(helpers): match Reflect.get
behaviour
#13862
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first call to
babelHelpers.get
substitutestarget
for falsy 3rd argumentreceiver
. That is not correct for several reasons:The reimplementation should follow
Reflect.get
spec, i.e. only substitutetarget
whenreceiver
argument is missing, not when it's falsy or nullish.Regarding tests, I think I know how to devise a test for the falsy receiver issue, but I have no idea how to test the first-call stub behaviour.