Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoist several closures #5837

Merged
merged 2 commits into from
Jun 12, 2017
Merged

Conversation

jridgewell
Copy link
Member

Q A
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? No
Fixed Tickets
License MIT
Doc PR
Dependency Changes

This hoists several helper closures by passing in the needed variables as parameters.

@jridgewell jridgewell added the PR: Polish 💅 A type of pull request used for our changelog categories label Jun 8, 2017
@codecov
Copy link

codecov bot commented Jun 9, 2017

Codecov Report

Merging #5837 into 7.0 will decrease coverage by <.01%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5837      +/-   ##
==========================================
- Coverage   85.09%   85.08%   -0.01%     
==========================================
  Files         284      284              
  Lines        9911     9912       +1     
  Branches     2768     2768              
==========================================
  Hits         8434     8434              
- Misses        976      977       +1     
  Partials      501      501
Impacted Files Coverage Δ
...ckages/babel-helper-builder-react-jsx/src/index.js 92.4% <100%> (ø) ⬆️
.../babel-plugin-transform-es2015-spread/src/index.js 95.38% <100%> (ø) ⬆️
packages/babel-traverse/src/path/family.js 75.72% <50%> (-0.75%) ⬇️
packages/babel-traverse/src/path/evaluation.js 69.23% <69.14%> (ø) ⬆️
packages/babel-traverse/src/path/context.js 84.48% <0%> (-0.87%) ⬇️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.63% <0%> (ø) ⬆️
packages/babel-traverse/src/visitors.js 86.66% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc1cbf...ac33b1b. Read the comment docs.

@jridgewell jridgewell merged commit 05726a9 into babel:7.0 Jun 12, 2017
@jridgewell jridgewell deleted the hoist-closure-helpers branch June 12, 2017 06:23
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: perf outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants