Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type errors for destructuring assignments(#4227) #5865

Merged
merged 1 commit into from
Jun 24, 2017

Conversation

MarckK
Copy link
Member

@MarckK MarckK commented Jun 16, 2017

Q A
Patch: Bug Fix? yes
Major: Breaking Change?
Minor: New Feature?
Deprecations?
Spec Compliancy?
Tests Added/Pass?
Fixed Tickets Fixes #4227
License MIT
Doc PR
Dependency Changes

@MarckK
Copy link
Member Author

MarckK commented Jun 16, 2017

Help welcome.
Needs test.

@codecov
Copy link

codecov bot commented Jun 16, 2017

Codecov Report

Merging #5865 into 7.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              7.0    #5865   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files         284      284           
  Lines        9963     9963           
  Branches     2781     2781           
=======================================
  Hits         8494     8494           
  Misses        969      969           
  Partials      500      500
Impacted Files Coverage Δ
packages/babel-types/src/definitions/es2015.js 96.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5387d9f...4231932. Read the comment docs.

@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jun 24, 2017
@hzoo hzoo merged commit b6b69c6 into babel:7.0 Jun 24, 2017
@hzoo
Copy link
Member

hzoo commented Jun 24, 2017

Can do the tests in another PR (or figure out how to test this part of the code in general) 😄 !

@MarckK MarckK deleted the fix4227/errors-destructuring-assignment branch June 26, 2017 07:48
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants