[plugin-proposal-class-properties] Fix small loose docs typo #6941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdgluck
changed the title
sdgluck
changed the title
| @@ -98,7 +98,7 @@ When `true`, class properties are compiled to use an assignment expression inste | |||
| } | |||
| ``` | |||
|
|
|||
| Without `{ "loose": true }`, the above code will compile to the following, using `Object.definePropery`: | |||
| Without `{ "loose": false }`, the above code will compile to the following, using `Object.definePropery`: | |||
There was a problem hiding this comment.
"Without { "loose": true }" seems correct, as in... when not in loose mode, it will use Object.defineProperty.
The real typo is Object.definePropery -> Object.defineProperty :)
Mind fixing/updating?
There was a problem hiding this comment.
Yeah you wouldn't use loose false, it is describing the default behavior
There was a problem hiding this comment.
@existentialism Updated 👍
existentialism
added
the
PR: Docs 📝
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6045/ |
|
@sdgluck thanks! |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.