Don't extract rest elements from nested expressions #7364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6902/ |
Andarist
reviewed
Feb 11, 2018
| }); | ||
| return foundRestElement; | ||
| } | ||
|
|
||
| function visitRestElements(path, visitor) { |
There was a problem hiding this comment.
I realize that this is probably more performant solution, but the code itself is imho a little bit convoluted, hard to read and to reason about. It has a lot of indirection in it. Would it be possible to rephrase it into a simpler implementation?
Andarist
reviewed
Feb 16, 2018
| const stop = visitor(path); | ||
| if (stop) return; | ||
| path.traverse({ | ||
| Expression(path) { |
There was a problem hiding this comment.
this is way easier to track! ❤️
Andarist
approved these changes
Feb 16, 2018
|
@nicolo-ribaudo I think this caused the merge conflict now for you - #7388 |
nicolo-ribaudo
force-pushed
the
obj-rest-nested-function
branch
from
d4d39c2
to
35032f6
Compare
nicolo-ribaudo
changed the title
existentialism
added
PR: Bug Fix 🐛
existentialism
approved these changes
Feb 17, 2018
aminmarashi
pushed a commit
to aminmarashi/babel
that referenced
this pull request
Mar 17, 2018
* Don't extract rest elements from nested expressions * Node 4
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the plugin didn't only traverse the destructuring pattern when searching for rest elements, but also default values.
I suggest to review this PR ignoring whitespaces (https:/babel/babel/pull/7364/files?w=1)