Corrected parsing of passed environment variables for GLOB and TAGS #352
Conversation
…for GLOB and TAGS This sets it to respect how Cypress expect and behaves with this flag allowing us to pass environment varibles along side TAGS and GLOB and have all variables be properly passed to Cypress. fixes #335
|
The first comment I noticed after testing this in another script that I had missed to negate the condition xD actually includes is even better xD I kept it with About the comment I usually like to document why certain behavior is done, especially that Cypress' behavior caught me off guard honestly, as normally array like options are taking by giving the parameter multiple times, so I wanted to document why it done this way. Thanks for your comments :D |
|
@dallevon I prefer to refrain from adding new features as this just intends to fix the bug in the behavior of this package 😅 except if the maintainers of the project want this to also be introduced I'd rather it just be the bug fix 😃 |
|
Understood. No problem. Thank you. |
|
Looks good. Thanks for the work and sorry for the late merge! |
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This sets it to respect how Cypress expect and behaves with this flag allowing us to pass
environment varibles along side TAGS and GLOB and have all variables be properly passed to Cypress.
fixes #335
fixes #244