[Docsrs] Use the latest build status for multiple builds #7613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
added
the
service-badge
services/docsrs/docsrs.service.js
Outdated
Comment on lines
55
to
57
| const { build_status: buildStatus } = ( | ||
| await this.fetch({ crate, version }) | ||
| ).pop() | ||
| ).shift() |
There was a problem hiding this comment.
Would you mind changing this to just destructure the first item in the array? I realize we were already mutating it and that in practice this will typically only have one element, but there's really no need to mutate the collection the first place
When documentation for a crate is rebuilt the `builds.json` can return multiple results, ordered latest first, so we must take the first element of the array rather than the last.
Nemo157
force-pushed
the
fix-docsrs-multiple-builds
branch
from
1a4b51f
to
877fa4f
Compare
calebcartwright
approved these changes
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When documentation for a crate is rebuilt the
builds.jsoncan return multiple results, ordered latest first, so we must take the first element of the array rather than the last.As an example currently https://img.shields.io/docsrs/bevy_tweening/0.3.1 is showing failing, despite the latest build in https://docs.rs/crate/bevy_tweening/0.3.1/builds.json being successful.