Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Netlify] upgrade colors for SVG parsing #8971

Merged
merged 1 commit into from
Mar 9, 2023
Merged

[Netlify] upgrade colors for SVG parsing #8971

merged 1 commit into from
Mar 9, 2023

Conversation

mistic100
Copy link
Contributor

Closes #8970

Example of passing badge
Example of failing badge

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Warnings
⚠️ This PR modified service code for netlify but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @mistic100!

Generated by 🚫 dangerJS against 2efa636

chris48s
chris48s approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having spent a bit of time looking at the new badges and the API, I have no better suggestion for how we can make this more robust.

@chris48s chris48s added service-badge Accepted and actionable changes, features, and bugs squash when passing labels Mar 9, 2023
@repo-ranger repo-ranger bot merged commit eb969fd into badges:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Netlify badge down
2 participants
@mistic100 @chris48s