Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call [pepy] with auth #9748

Merged
merged 1 commit into from
Nov 19, 2023
Merged

call [pepy] with auth #9748

merged 1 commit into from
Nov 19, 2023

Conversation

chris48s
Copy link
Member

Closes #9730
Refs psincraian/pepy#573 (comment)

Not much actual code needed here, but a fair bit of admin around it. I've set

SERVICETESTS_PEPY_KEY in

PEPY_KEY is already set in prod and staging envs on fly

Creds are in keybase and invites sent.

@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Nov 18, 2023
Copy link
Contributor

Warnings
⚠️ This PR modified the server but none of its tests.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for pepy but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against cba86cf

Copy link
Contributor

🚀 Updated review app: https://pr-9748-badges-shields.fly.dev

1 similar comment
Copy link
Contributor

🚀 Updated review app: https://pr-9748-badges-shields.fly.dev

Copy link
Contributor

🚀 Updated review app: https://pr-9748-badges-shields.fly.dev

@chris48s
Copy link
Member Author

Can confirm service tests and review apps working with credentials. I had to run the "Create/Update Review App" workflow from the 9730-pepy branch to get it to pick up the new secret.

@chris48s
Copy link
Member Author

I'm going to go ahead and merge this one. Fixing this seems non-controversial

@chris48s chris48s merged commit 19b50a6 into master Nov 19, 2023
38 checks passed
@chris48s chris48s deleted the 9730-pepy branch November 19, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pepy Downloads Badge "invalid" on any package
1 participant