Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure social category badges are rendered with social style and logo; affects [gitlab keybase lemmy modrinth thunderstore twitch] gist github reddit #9859

Merged
merged 2 commits into from
Dec 31, 2023

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Dec 30, 2023

Fixes #9704 by rendering all badges in the social category with the social style and a logo by default.

@PyvesB PyvesB added the service-badge Accepted and actionable changes, features, and bugs label Dec 30, 2023
Copy link
Contributor

github-actions bot commented Dec 30, 2023

Warnings
⚠️ This PR modified service code for github/gist but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for gitlab but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for keybase but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for lemmy but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for modrinth but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for reddit but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for thunderstore but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for twitch but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against 9ee9577

@chris48s chris48s changed the title Ensure social category badges are rendered with social style and logo Ensure social category badges are rendered with social style and logo; affects [gist github gitlab keybase lemmy modrinth reddit thunderstore twitch] Dec 30, 2023
Copy link
Contributor

🚀 Updated review app: https://pr-9859-badges-shields.fly.dev

@chris48s chris48s changed the title Ensure social category badges are rendered with social style and logo; affects [gist github gitlab keybase lemmy modrinth reddit thunderstore twitch] Ensure social category badges are rendered with social style and logo; affects [gitlab keybase lemmy modrinth thunderstore twitch] gist github reddit Dec 30, 2023
@chris48s
Copy link
Member

Changes look good. Can you have a look at the failing twitch auth tests? I expect we just need to update the expected value.

@PyvesB
Copy link
Member Author

PyvesB commented Dec 30, 2023

Yeah, I've been fighting against unstable connectivity from a train, I'll circle back to this tomorrow. :)

@chris48s chris48s added this pull request to the merge queue Dec 31, 2023
Merged via the queue into badges:master with commit 04254e5 Dec 31, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default style for social badges in documentation
2 participants