[Maven] Added badge for Maven-Cenral last-update (#10301) #10585
+94
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MohanKumarAmbati
changed the title
MohanKumarAmbati
changed the title
chris48s
added
the
service-badge
chris48s
reviewed
Oct 11, 2024
| return this._requestXml({ | ||
| schema, | ||
| url: `https://repo1.maven.org/maven2/${group}/${artifact}/maven-metadata.xml`, | ||
| httpErrors: { 404: 'solution not found' }, |
There was a problem hiding this comment.
What is the significance of the word "solution" here? Given the names of the params, I'd assume "artifact not found" would be the error here
Comment on lines
51
to
56
| const date = new Date( | ||
| `${metadata.versioning.lastUpdated}`.replace( | ||
| /^(\d{4})(\d\d)(\d\d)(\d\d)(\d\d)(\d\d)$/, | ||
| '$4:$5:$6 $2/$3/$1', | ||
| ), | ||
| ) |
There was a problem hiding this comment.
Instead of trying to do this with regex, lets use dayjs to:
- parse this
- make sure it is valid
- throw an exception if it is not
We can pass a dayjs object straight to formatDate() and ageColor()
Suggested code:
import dayjs from 'dayjs'
import { InvalidResponse } from '../index.js'
const date = dayjs(metadata.versioning.lastUpdated, "YYYYMMDDHHmmss")
if (!date.isValid()) {
throw new InvalidResponse({ prettyMessage: 'invalid date' })
}
return this.constructor.render({ date })
|
🚀 Updated review app: https://pr-10585-badges-shields.fly.dev |
chris48s
approved these changes
Oct 12, 2024
|
Thank you @chris48s, this is a very special to me as it is my first contribution towards open-source. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @chris48s, can you please add hacktoberfest-accepted label to this PR so that it is considered under it.
closes - #10301
Thanks in advance.