Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor version rendering in [wordpress nexus] and [f-droid] services #10608

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Refactor version rendering in [wordpress nexus] and [f-droid] services #10608

merged 2 commits into from
Oct 13, 2024
+7 −30

Conversation

jNullj
Copy link
Collaborator

@jNullj jNullj commented Oct 12, 2024

We mostly use the short more elegant renderVersionBadge but some services still use older method of directly calling addv and versionColor.

These changes refactor the WordpressVersion, Nexus and FDroid services to fit usage of renderVersionBadge

@jNullj jNullj added service-badge Accepted and actionable changes, features, and bugs javascript Pull requests that update Javascript code labels Oct 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024 •
edited
Loading

Warnings
⚠️ This PR modified service code for f-droid but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for nexus but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for wordpress but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against d1d60db

@jNullj jNullj changed the title Refactor version rendering in [WordpressVersion Nexus] and [FDroid] services Refactor version rendering in [wordpress nexus] and [f-droid] services Oct 12, 2024
@jNullj
Copy link
Collaborator Author

jNullj commented Oct 12, 2024

I think service test failed for nexus due to upstrem changes
https:/badges/shields/actions/runs/11306263530?pr=10608
I get the same issue at the master branch

@jNullj jNullj mentioned this pull request Oct 12, 2024
Merged
PyvesB
PyvesB approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jNullj, this looks great! We're making slow progress on #2026, maybe one day we'll be able to close it 😄

@PyvesB PyvesB merged commit d00c4de into badges:master Oct 13, 2024
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jNullj @PyvesB