Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pypi] Improve formatting of trove-based licenses #3265

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

paulmelnikow
Copy link
Member

Currently the trove-based license classifiers generate different formatting than the legacy license classifiers. This brings them into alignment.

Production:

This PR:

Think this is a good improvement; more consistent with most other badges, and will look better on readmes (see https:/lace/vg for an example).

@paulmelnikow paulmelnikow added the service-badge Accepted and actionable changes, features, and bugs label Apr 4, 2019
@shields-ci
Copy link

shields-ci commented Apr 4, 2019

Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 89720df

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calebcartwright
Copy link
Member

Semi-related, I noticed that the color schemes applied on license badges vary between license services as well. Is that intentional or worth potentially trying to make them consistent at some point in the future?

@paulmelnikow
Copy link
Member Author

Yes! There's some discussion of that at #2026.

@paulmelnikow paulmelnikow merged commit 766d55e into master Apr 4, 2019
@paulmelnikow paulmelnikow deleted the capitalize-mit-license branch April 4, 2019 11:22
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants