Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate request to got (part 1 of many) #6160

Merged
merged 10 commits into from
Mar 9, 2021
Merged

Commits on Feb 27, 2021

  1. install new packages

    chris48s committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    fdeb60d View commit details
    Browse the repository at this point in the history
  2. migrate request to got

    chris48s committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    62cadce View commit details
    Browse the repository at this point in the history
  3. update dynamic json test

    This is a behavioural difference between request and got
    
    request will send the request, then we'll get a
    `400 Bad Request` back and re-throw at as invalid
    
    got will pick up that the URL is invalid and throw
    `RequestError: URI malformed` before attempting to send it
    which we'll re-throw as inaccessible
    chris48s committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    0312647 View commit details
    Browse the repository at this point in the history
  4. fix OPM service

    chris48s committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    eff1019 View commit details
    Browse the repository at this point in the history
  5. fix wordpress querystring

    Got doesn't natively support assmebling a querystring
    from nested objects because it uses node's URLSearchParams
    internally. Use qs and pass qs a string.
    
    Wordpress is the only service that needs this,
    so we could build the string manually in this case
    if we don't want to take qs as a prod dependency.
    It is mostly hard-coded values anyway.
    chris48s committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    c0e8e85 View commit details
    Browse the repository at this point in the history
  6. fix wercker

    got overwrites any ?foo=bar in the URL string if
    searchParams is also passed whereas request appends
    see https:/sindresorhus/got#url
    chris48s committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    c32bc59 View commit details
    Browse the repository at this point in the history
  7. fix keybase

    chris48s committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    bb644cc View commit details
    Browse the repository at this point in the history
  8. add tests for got wrapper

    chris48s committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    7cfa477 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    94f8c43 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Configuration menu
    Copy the full SHA
    f19a894 View commit details
    Browse the repository at this point in the history