Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove request from legacy request handler; affects [librariesio github] #7233

Merged
merged 2 commits into from
Nov 6, 2021
Merged

remove request from legacy request handler; affects [librariesio github] #7233

merged 2 commits into from
Nov 6, 2021

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Nov 5, 2021

refs #4655
delete a bunch of stuff we don't need any more

@chris48s chris48s added core Server, BaseService, GitHub auth, Shared helpers dependencies Related to dependency updates labels Nov 5, 2021
@shields-ci
Copy link

shields-ci commented Nov 5, 2021 •
edited
Loading

Warnings
⚠️

📚 Remember to ensure any changes to config.private in services/github/auth/acceptor.js are reflected in the server secrets documentation
Messages
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 3a76018

@chris48s chris48s mentioned this pull request Nov 5, 2021
Closed
@chris48s chris48s changed the title remove request from legacy request handler; run [*****] remove request from legacy request handler; affects [librariesio github] Nov 5, 2021
calebcartwright
calebcartwright approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the utilization of some of these (caching in particular) eliminated as part of the more holistic got migration, or was it already dead code?

@chris48s
Copy link
Member Author

chris48s commented Nov 6, 2021

Yeah its a good question. Now I've done this, I think this was actually dead code before #6160 although I haven't pinpointed the exact commit where it became unreachable. Working on #4655 has just forced me to actually read and understand this function a bit :)

@repo-ranger repo-ranger bot merged commit f1b643d into badges:master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers dependencies Related to dependency updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris48s @shields-ci @calebcartwright