Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pub] Use official version endpoint for pub-service #9802

Merged
merged 4 commits into from
Dec 12, 2023
Merged

[pub] Use official version endpoint for pub-service #9802

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0859c02
Use official version endpoint for pub-service
sigurdm Dec 11, 2023
df3595d
run prettier
sigurdm Dec 11, 2023
15a69e7
Update schema
sigurdm Dec 12, 2023
4da8f3f
make services a required property
chris48s Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions services/pub/pub.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import { BaseJsonService, redirector, pathParam, queryParam } from '../index.js'
import { baseDescription } from './pub-common.js'

const schema = Joi.object({
versions: Joi.array().items(Joi.string()).required(),
versions: Joi.array()
.items(Joi.object({ version: Joi.string().required() }))
.required(),
}).required()

const queryParamSchema = Joi.object({
Expand Down Expand Up @@ -45,14 +47,14 @@ class PubVersion extends BaseJsonService {
async fetch({ packageName }) {
return this._requestJson({
schema,
url: `https://pub.dartlang.org/packages/${packageName}.json`,
url: `https://pub.dev/api/packages/${packageName}`,
})
}

async handle({ packageName }, queryParams) {
const data = await this.fetch({ packageName })
const includePre = queryParams.include_prereleases !== undefined
const versions = data.versions
const versions = data.versions.map(x => x.version)
const version = latest(versions, { pre: includePre })
return renderVersionBadge({ version })
}
Expand Down
Loading