Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprints action destroy is not called with meta #5630

Closed
Alessy opened this issue May 20, 2019 · 6 comments · Fixed by #6847
Closed

Blueprints action destroy is not called with meta #5630

Alessy opened this issue May 20, 2019 · 6 comments · Fixed by #6847
Labels
blueprints Issue only occurs when using the blueprint API resolved

Comments

@Alessy
Copy link

Alessy commented May 20, 2019

Node version: 8.16.0
Sails version (sails): 1.2.2
ORM hook version (sails-hook-orm): 2.1.1
DB adapter & version (e.g. sails-mysql): 1.0.1


From documentation:

The afterDestroy lifecycle callback will only be run on .destroy() queries that have the fetch meta flag set to true.

Blueprints action destroy don't include meta object so afterDestroy lifecycle callback don't run.

@sailsbot
Copy link

@Alessy Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@johnabrams7 johnabrams7 added blueprints Issue only occurs when using the blueprint API inconsistency labels May 20, 2019
@johnabrams7
Copy link
Contributor

johnabrams7 commented May 20, 2019

@Alessy - Thanks for spotting that, I'll bring it up to the team. If you're reaching a point were Blueprints is no longer working out of the box, it's ok to go ahead and write a backend action instead of using blueprint actions as a workaround 👍

@dukewan
Copy link

dukewan commented Aug 18, 2019

Same issue here, it was called before.

@johnabrams7
Copy link
Contributor

@dukewan As a workaround, have you tried using a backend action instead of a blueprint action for your project?

@dukewan
Copy link

dukewan commented Aug 24, 2019

@johnabrams7 I didn’t, I used the beforeDestroy hook instead which is not ideal but works for me.

rachaelshaw added a commit that referenced this issue Aug 24, 2019
[fixes #5630] Update destroy blueprint action so that `afterDestroy` lifecycle callbacks will still run by default
@rachaelshaw
Copy link
Member

@Alessy @dukewan @johnabrams7 just fixed this in #6847

@rachaelshaw rachaelshaw added resolved and removed bug labels Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blueprints Issue only occurs when using the blueprint API resolved
5 participants