Latest version of connect-mongo not supported by session hook

[ElizabethForest]

Node version: v10.6.0
Sails version (sails): v1.4.4
ORM hook version (sails-hook-orm): v3.0.2
Sockets hook version (sails-hook-sockets): v2.0.1
Organics hook version (sails-hook-organics): -
Grunt hook version (sails-hook-grunt): v4.0.1
Uploads hook version (sails-hook-uploads): -
DB adapter & version (e.g. [email protected]): -
Skipper adapter & version (e.g. [email protected]): -
connect-mongo version: v4.5.0

---

The latest version of connect-mongo (v4) is not supported by the Sails session hook. This is a problem for me because it implements an important bug fix.

The connect-mongo update is a breaking change with the key difference (mentioned in the connect-mongo migration docs):

Create the store using MongoStore.create(options) instead of new MongoStore(options)

This causes an error at https:/balderdashy/sails/blob/master/lib/hooks/session/index.js#L405

error: Failed to lift app: Error: Encountered error attempting to instantiate a session store using the installed version of `connect-mongo` (a session adapter).
Raw error from the session adapter:
---
TypeError: Class constructor MongoStore cannot be invoked without 'new'
    at afterMaybeConnectToRedis (/opt/redbox-portal/node_modules/sails/lib/hooks/session/index.js:405:33)
    ...

I am happy to look at implementing a fix and submitting a PR. I assume the fix would need to be backwards compatible with the older versions of connect-mongo?

[sailsbot]

@ElizabethForest Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.