Overload NonTerminalNode.findNode() to include start offset and improve related create function code action usage #28936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMS94
changed the title
IMS94
force-pushed
the
create-fn-code-action
branch
from
919860c
to
f8613c3
Compare
1. Overload NonTerminalNode.findNode() method to expose a new API to include start offset when searching for a child node. 2. Update 'Create Function Code Action' to support undefined methods within records and let expressions 3. Fix failing tests after updating CommonUtil.findNode() method to include start offset when searching for a node
IMS94
force-pushed
the
create-fn-code-action
branch
from
f8613c3
to
180add4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
CommonUtil.findNode()method to include start offset when searching for a nodeApproach
See decription + #28921 discussion
Check List