Add support for Server-Sent Events #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedSabthar
requested review from
shafreenAnfar and
TharmiganK
as code owners
ayeshLK
reviewed
Jul 29, 2024
ayeshLK
reviewed
Jul 29, 2024
| } | ||
|
|
||
| private ByteBuf getBuffer() { | ||
| if (pooledByteBufAllocator == null) { |
There was a problem hiding this comment.
Suggested change
| if (pooledByteBufAllocator == null) { | |
| if (Objects.isNull(pooledByteBufAllocator)) { |
There was a problem hiding this comment.
Since this is imperative code, we can keep the original, right? Are there any additional advantages to using this?
ayeshLK
reviewed
Jul 29, 2024
native/src/main/java/io/ballerina/stdlib/http/transport/message/HttpMessageDataStreamer.java
Show resolved
Hide resolved
Co-authored-by: DimuthuMadushan <[email protected]> Co-authored-by: Ayesh Almeida <[email protected]>
TharmiganK
reviewed
Jul 29, 2024
native/src/main/java/io/ballerina/stdlib/http/transport/contractimpl/common/Util.java
Show resolved
Hide resolved
TharmiganK
reviewed
Jul 30, 2024
ballerina-tests/http-advanced-tests/tests/server_sent_event_tests.bal
Outdated
Show resolved
Hide resolved
ballerina-tests/http-advanced-tests/tests/server_sent_event_tests.bal
Outdated
Show resolved
Hide resolved
ballerina-tests/http-advanced-tests/tests/server_sent_event_tests.bal
Outdated
Show resolved
Hide resolved
ballerina-tests/http-advanced-tests/tests/server_sent_event_tests.bal
Outdated
Show resolved
Hide resolved
ballerina-tests/http-advanced-tests/tests/server_sent_event_tests.bal
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/http/transport/contractimpl/common/Util.java
Show resolved
Hide resolved
TharmiganK
reviewed
Jul 30, 2024
|
TharmiganK
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: ballerina-platform/ballerina-library#6687
Examples
Checklist