-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: embedding icons #132
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
da14eb0
refactor: build icon
FoundTheWOUT 2a04db7
build script
FoundTheWOUT 8405e1c
build before test
FoundTheWOUT 361cfc5
optimize
FoundTheWOUT f4eb53c
Merge branch 'master' of https:/bangumi/frontend into icons
FoundTheWOUT d5b2df2
Merge remote-tracking branch 'upstream/master' into icons
trim21 23a2812
Merge remote-tracking branch 'upstream/master' into icons
trim21 94ae393
Update packages/icons/scripts/build.js
FoundTheWOUT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
const { readdir, readFile, writeFile, mkdir, access, constants } = require('fs/promises'); | ||
const { resolve, join } = require('path'); | ||
const { transform } = require('@svgr/core'); | ||
const { rmSync } = require('fs'); | ||
|
||
const OUT_DIR = resolve('./dist'); | ||
const capitalize = (str) => str[0].toUpperCase() + str.slice(1); | ||
|
||
async function main() { | ||
try { | ||
await access(OUT_DIR, constants.F_OK); | ||
rmSync(OUT_DIR, { force: true, recursive: true }); | ||
} catch (error) {} | ||
|
||
await mkdir(OUT_DIR); | ||
|
||
try { | ||
const icons = await readdir('./assets/'); | ||
let indexContent = ''; | ||
|
||
for (const icon of icons) { | ||
const [filename] = icon.split('.'); | ||
const defaultName = filename.split('-').map(capitalize).join(''); | ||
const svg = (await readFile(resolve('./assets', icon))).toString(); | ||
|
||
const svgComponents = await transform(svg); | ||
const svgComponentsDts = `import * as React from 'react'; | ||
declare function ${defaultName}(props: React.ComponentProps<'svg'>): JSX.Element; | ||
export default ${defaultName}; | ||
`; | ||
indexContent += `export { default as ${defaultName} } from "./${filename}.jsx"\n`; | ||
|
||
// create jsx | ||
await writeFile(join(OUT_DIR, `${filename}.jsx`), svgComponents); | ||
await writeFile(join(OUT_DIR, `${filename}.d.ts`), svgComponentsDts); | ||
} | ||
|
||
// export all svg | ||
await writeFile(join(OUT_DIR, 'index.js'), indexContent, { encoding: 'utf-8' }); | ||
await writeFile(join(OUT_DIR, 'index.d.ts'), indexContent, { encoding: 'utf-8' }); | ||
} catch (error) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这里不用catch吧,catch了之后构建失败只有一个console.error了,依旧会去构建后面的website |
||
console.error(error); | ||
} | ||
} | ||
|
||
main().catch(e => { | ||
throw e; | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉build越来越复杂了...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还好吧,才两个build(
可以写下script,或者上turborepo