Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): implement image #49

Merged
merged 12 commits into from
Mar 13, 2022
Merged

feat(design): implement image #49

merged 12 commits into from
Mar 13, 2022

Conversation

cijiugechu
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #49 (faa128c) into master (1c23b7e) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   99.08%   99.18%   +0.09%     
==========================================
  Files          14       15       +1     
  Lines         437      490      +53     
  Branches       47       48       +1     
==========================================
+ Hits          433      486      +53     
  Misses          4        4              
Impacted Files Coverage Δ
packages/design/components/Image/index.tsx 100.00% <100.00%> (ø)
packages/design/index.tsx 100.00% <100.00%> (ø)
packages/design/components/Tab/index.tsx 100.00% <0.00%> (ø)
packages/design/components/Rate/index.tsx 100.00% <0.00%> (ø)
packages/design/components/Divider/index.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c23b7e...faa128c. Read the comment docs.

@github-actions
Copy link
Contributor

preview url: https://pr-49--bangumi-next.netlify.app

@cijiugechu cijiugechu marked this pull request as ready for review March 10, 2022 13:57
@cokemine
Copy link
Contributor

border-radius: 6px;好像常会用到或许可以设置个 Props 设置一个圆角效果。

cijiugechu and others added 3 commits March 11, 2022 00:48
@cokemine
Copy link
Contributor

@cijiugechu object-fit 应该是只对 img 标签可以生效,这里还得改一下(x
borderRadius应该只常用到6px 不需要提取出来直接内联样式,可以加一个 class &--xxxxx { border-radius: 6px }
外层 div 应该没有必要内联设置 width 和 height

@cijiugechu
Copy link
Contributor Author

@cijiugechu object-fit 应该是只对 img 标签可以生效,这里还得改一下(x borderRadius应该只常用到6px 不需要提取出来直接内联样式,可以加一个 class &--xxxxx { border-radius: 6px } 外层 div 应该没有必要内联设置 width 和 height

感觉可以在 props 里加一个 类似于 shape 的属性,大概长这样:shape?: 'rect' | 'circle' , 然后默认 rect 指定圆角为 6px

@Ayase-252 Ayase-252 merged commit c434ee6 into bangumi:master Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants