Removed file caching to allow live reloading of files #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,8 +49,7 @@ def self.comment_helper(source_location, name=nil) | |||
| # @return [Array<String>] the contents of the file | |||
| # @raise [SourceNotFoundError] | |||
| def self.lines_for(file_name, name=nil) | |||
| @lines_for_file ||= {} | |||
| @lines_for_file[file_name] ||= File.readlines(file_name) | |||
| File.readlines(file_name) | |||
There was a problem hiding this comment.
Ah good catch, but i wonder how badly this slows things down in tools that use this functionality (like Pry).
Maybe it would be better to move to a helper object that does the memoization but which gets thrown away when it's no longer being used. Really silly of us (probably me) to put the memoization on the actual module itself!
There was a problem hiding this comment.
How long should the files be memoized for?
|
I'd be good to have a public API to delete a file from this hash, right now I'm doing this MethodSource.instance_variable_get(:@lines_for_file).delete(absolute_path)but it feels kind of weird 🤔, thanks guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way if you reload a file that defines a proc or a method the source updates. It also prevents
SourceNotFounderrors in case the proc or method definition moves within the file.