Switch Redis to Valkey in deploy template and tests #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Raised PR in kamal-site repo to update redis occurrences with valkey basecamp/kamal-site#129 |
|
I'd just change the image being used, not everything else. In many setups, including Rails, you're going to need to continue to use references like REDIS_URL for compatibility. But do like changing the image. |
|
Ah I see, makes sense @dhh. Updated the PR to just change the image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @dhh in #1044 (comment), this PR replaces Redis with Valkey (the FOSS fork of Redis) in deploy template and tests.
The deploy template now uses
valkey/valkey:8image for cache, which is the latest release with performance improvements over Valkey 7 / Redis 7, and still retains full compatibility with Redis OSS 7.2, which means the current ruby adapter for redis remains compatible.