Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: image_common should NOT be a submodule #247

Open
ndahn opened this issue Oct 11, 2024 · 0 comments
Open

BUG: image_common should NOT be a submodule #247

ndahn opened this issue Oct 11, 2024 · 0 comments

Comments

@ndahn
Copy link

ndahn commented Oct 11, 2024

Issue description

image_common should be a be a dependency in e.g. pylon_ros2_camera_component/package.xml, not a submodule. I'm not sure why this was ever approved, but it messes things up if people already have image_common in their workspace (e.g. a fork) as there are now multiple packages with the same name.

Code example about how to reproduce the issue

  1. Clone image_common into your workspace
  2. Clone pylon-ros-camera into your workspace
  3. Run git submodule --init --recursive
  4. Try to build your workspace

Error message

RuntimeError: Multiple packages found with the same name "camera_calibration_parsers":
- drivers/pylon_ros_camera/image_common/camera_calibration_parsers
- utils/image_common/camera_calibration_parsers
Multiple packages found with the same name "camera_info_manager":
- drivers/pylon_ros_camera/image_common/camera_info_manager
- utils/image_common/camera_info_manager
Multiple packages found with the same name "image_common":
- drivers/pylon_ros_camera/image_common/image_common
- utils/image_common/image_common
Multiple packages found with the same name "image_transport":
- drivers/pylon_ros_camera/image_common/image_transport
- utils/image_common/image_transport

Hardware setup description

Runtime information

-

Is your camera operational with the Basler pylon Viewer on your platform?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant