Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make root workspace bzlmod only #915

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Aug 20, 2024

Reduce the maintenance burden caused by duplication of Bazel deps in the root workspace.

CI coverage for WORKSPACE is still in-place in all the e2e workspaces.


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

Copy link

aspect-workflows bot commented Aug 20, 2024

Test

12 test targets passed

Targets
//:bazel_version_test [k8-fastbuild]                                         243ms
//lib/tests/bats:args [k8-fastbuild]                                         3s
//lib/tests/bats:basic [k8-fastbuild]                                        3s
//lib/tests/bats:env [k8-fastbuild]                                          3s
//lib/tests/bats:env_expansion [k8-fastbuild]                                3s
//lib/tests/copy_to_directory:case_22_test [k8-fastbuild]                    459ms
//lib/tests/copy_to_directory_bin_action:test [k8-fastbuild]                 445ms
//lib/tests/jq:check_stamped [k8-fastbuild]                                  256ms
//lib/tests/yq:check_stamped [k8-fastbuild]                                  172ms
//shlib/tests/lib_tests/assertions_tests:assert_equal_test [k8-fastbuild]    322ms
//shlib/tests/lib_tests/assertions_tests:assert_match_test [k8-fastbuild]    420ms
//shlib/tests/lib_tests/assertions_tests:assert_no_match_test [k8-fastbuild] 629ms

Total test execution time was 15s. 209 tests (94.6%) were fully cached saving 45s.


Test

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 750ms.


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 742ms.


Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 1s.


Buildifier      Format      Gazelle

@gregmagolan gregmagolan force-pushed the root_workspace_bzlmod_only branch 7 times, most recently from 5fac227 to aa08410 Compare August 20, 2024 14:11
deps.bzl Show resolved Hide resolved
@gregmagolan gregmagolan merged commit cccf5ac into main Aug 20, 2024
33 checks passed
@gregmagolan gregmagolan deleted the root_workspace_bzlmod_only branch August 20, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants