-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue enabling layering_check
#1221
Comments
rules_foreign_cc disables layering checks because the flags that this feature set are not safe to pass to a third party build system. |
The API for creating and adding module maps is private, so the only thing you could try now is to split up the |
I'm using
openssl
viaconfigure_make
:And then enable the
layering_check
feature on acc_library
that depends on "@openssl":But
layering_check
does not seem to think thatopenssl
is exporting certain header files:I can see these header files in the build cache include directories, so I'm just guessing that the rule for openssl doesn't have these headers declared?
Is this expected behavior, or how can I go about debugging this?
EDIT:
It does seem as though rules_foreign_cc disables layering checks. But I'm still a bit lost on how to deal with adding layering checks to libraries that depend on a library built with rules_foreign_cc as it doesn't appear to declare the output headers explicitly.
The text was updated successfully, but these errors were encountered: