Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change all cfg=host and cfg=target executable attributes to cfg=exec #3215

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

gregmagolan
Copy link
Collaborator

These should have been "exec" all along.

@gregmagolan gregmagolan changed the title fix: change all cfg=host configs to cfg=exec fix: change all cfg=host and cfg=target attrributes to cfg=exec Jan 11, 2022
@gregmagolan gregmagolan changed the title fix: change all cfg=host and cfg=target attrributes to cfg=exec fix: change all cfg=host and cfg=target executable attributes to cfg=exec Jan 11, 2022
@gregmagolan gregmagolan force-pushed the cfg_exec branch 10 times, most recently from b56c710 to dc751fd Compare January 11, 2022 10:44
"../bazel-out/darwin-dbg/bin/src",
"../bazel-out/darwin-fastbuild/bin/src",
"../bazel-out/darwin_arm64-fastbuild/bin/src",
"../bazel-out/darwin-opt-exec-2B5CBBC6/bin/src",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know what the 2B5CBBC6 is based on? I hope it's a stable checksum that will match on another machine.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

John Cater says "the hex tag is just a hash of the execution platform" (bazelbuild/bazel#12403 (comment)) so it should be stable. Guessing it is a hash of "host" if the exec platform is the host since it is stable between k8, darwin & windows in these paths


// Ensures that args are well formed.
// Work-around for an issue on Windows when exec bin path is not quoted.
// In --source-map, base=bazel-out/x64_windows-opt-exec-2B5CBBC6/bin must
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting we didn't have this problem before, we had hyphens in the path already right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I was puzzled. The extra -exec-2B5CBBC6 broke it when there were no quotes 🤷 Something fishy upstream

@gregmagolan gregmagolan merged commit 9fd3fb9 into bazel-contrib:5.x Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants