-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI support base commit hash file as an input #3
Comments
Thanks for filing this issue! I think this makes a lot of sense - definitely being able to cache these values across runs is very sensible. Would you be interested in trying to put together a PR to implement this? The key pieces of code to affect would be:
As far as I know, everything in We may want to nil-out any instances of |
We are considering trying out target-determinator in Diff CI, but we have some performance constraints.
Can we add CLI that supports taking in an already computed hash file from master to avoid git checkout base commit and perform a cquery on the base commit for comparison? This is a feature in https:/Tinder/bazel-diff#get-impacted-targets-command
With this feature, we can compute hash file in master CI and reuse the result in diff CI and save us seconds to minutes.
The text was updated successfully, but these errors were encountered: