Skip to content

Commit

Permalink
Don't call removeReverseDep on a non-incremental node entry in tests.
Browse files Browse the repository at this point in the history
It's illegal. There must be some race in propagating the failure from the async thread since the test is only flakily failing since 20c541c (albeit at a very high rate).

PiperOrigin-RevId: 556074380
Change-Id: I6c177d0346cb9849b5aa81c104ad9295548f5a84
  • Loading branch information
justinhorvitz authored and pull[bot] committed Sep 29, 2023
1 parent 931019d commit 3449738
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,9 @@ public void testAddRemoveRdeps() throws Exception {
waitForAddedRdep.countDown();
waitForSetValue.await(TestUtils.WAIT_TIMEOUT_SECONDS, SECONDS);
for (int k = chunkSize; k <= numIterations; k++) {
entry.removeReverseDep(key("rdep" + j));
if (shouldTestIncrementality()) {
entry.removeReverseDep(key("rdep" + j));
}
entry.addReverseDepAndCheckIfDone(key("rdep" + j));
if (shouldTestIncrementality()) {
entry.getReverseDepsForDoneEntry();
Expand Down

0 comments on commit 3449738

Please sign in to comment.