-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aquery and --build_tests_only do not work together in Bazel 5.0 #14505
Comments
/cc @Wyverald |
Perhaps more succinctly, why is this happening in 5.0.0rc3? $ bazel --nohome_rc aquery --build_tests_only -- @com_google_googletest//:all | grep -c gtest-death-test
...
0 even though I get this in 4.2.2? $ bazel --nohome_rc aquery --build_tests_only -- @com_google_googletest//:all | grep -c gtest-death-test
...
12 |
For posterity, the BUILD file in question: https:/google/googletest/blob/609281088cfefc76f9d0ce82e1ff6c30cc3591e5/BUILD.bazel From running the command in 4.2.2 vs 5.0.0rc3 myself, it looks like 5.0.0rc3 just does not contain aquery stuff for the :gtest target. I know next to nothing about how aquery works, unfortunately, so I'll ask for more help. In the meantime, how did you come upon this, @philsc? Did you notice it from aquery logs, or was some other build action failing? |
After removing the --build_tests_only flag, the output from both versions looks about the same. So it looks like this issue is only about some change in the interaction between aquery and --build_test_only. @haxorz pointed out that it may be a bad idea to use those together anyhow: (the quote is about cquery but the same may apply to aquery)
Now we're still not quite sure what exactly caused this change, but given the circumstances I don't think this will count as a release blocker. |
I think that this is also a result of ebac27e:
|
What is |
@Wyverald 's quote of me had the context of a |
Okay, this feels like intended behaviour to me. I don't have a use case that requires interaction between
@Wyverald , It came to my attention because 5.0.0rc3 causes ~5000 of our CI tests to fail with this message:
I was using Thanks for the insight! I really appreciate it 👍 |
Are we concerned about potential interplay with I am OK with holding until a more compelling issue arises (partly because I don't have much knowledge of aquery and what the expected behaviors really are here excluding |
Actually, let me summarize my understanding: The behavior of how the aquery command and |
Description of the problem / feature request:
I'm debugging some strange dynamic linker errors in our CI tests related to gtest and absl when I switch from 4.2.2 to 5.0.0rc3.
This bug report is based on some of the investigation I've done. I suspect that this issue is related, but I'm not sure.
With this setup:
and an empty top-level BUILD file, I get the following with 4.2.2:
but with 5.0.0rc3 I get this:
In other words, bazel reports no actions for this file.
What operating system are you running Bazel on?
Ubuntu 18.04.
What's the output of
bazel info release
?Have you found anything relevant by searching the web?
I couldn't find anything on the Github issues list for this.
The text was updated successfully, but these errors were encountered: