Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules_kotlin fails with Bazel@head on ubuntu #18300

Closed
sgowroji opened this issue May 3, 2023 · 4 comments
Closed

rules_kotlin fails with Bazel@head on ubuntu #18300

sgowroji opened this issue May 3, 2023 · 4 comments
Labels

Comments

@sgowroji
Copy link
Member

sgowroji commented May 3, 2023

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2995#0187df5e-739d-4fa5-b106-11ef5af7e8d3

Platform : rules_kotlin (RBE (:ubuntu: 16.04, OpenJDK 8))

Logs:



==================== Test output for //src/test/kotlin/io/bazel/kotlin:KotlinJvmBasicAssertionTest:
--
  | java.lang.NoSuchMethodError: java.util.Set.of(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;)Ljava/util/Set;
  | at com.google.testing.junit.runner.junit4.JUnit4RunnerModule.setOfRunListeners(JUnit4RunnerModule.java:130)
  | at com.google.testing.junit.runner.junit4.JUnit4Bazel.initialize(JUnit4Bazel.java:75)
  | at com.google.testing.junit.runner.junit4.JUnit4Bazel.<init>(JUnit4Bazel.java:52)
  | at com.google.testing.junit.runner.junit4.JUnit4Bazel$Builder.build(JUnit4Bazel.java:102)
  | at com.google.testing.junit.runner.BazelTestRunner.runTestsInSuite(BazelTestRunner.java:144)
  | at com.google.testing.junit.runner.BazelTestRunner.main(BazelTestRunner.java:76)
  |  


Steps followed:

  1. git clone -v https:/bazelbuild/rules_kotlin.git
  2. cd rules_kotlin
  3. git reset 1d2a56d59c54c51d31cf0710d53ea9e43de03f63 --hard
  4. export USE_BAZEL_VERSION=11d1ffecd4994e4d6fa72306174444a80f97793b
  5. bazel test //src/test/kotlin/io/bazel/kotlin/builder:builder_tests //src/test/kotlin/io/bazel/kotlin:KotlinJvmAssociatesBasicVisibilityTest //src/test/kotlin/io/bazel/kotlin:KotlinJvmBasicAssertionTest

CC @meteorcloudy

@sgowroji sgowroji changed the title rules rules_kotlin fails with Bazel@head in ubuntu CI May 3, 2023
@sgowroji sgowroji changed the title rules_kotlin fails with Bazel@head in ubuntu CI rules_kotlin fails with Bazel@head on ubuntu May 3, 2023
@sgowroji sgowroji added breakage team-Android Issues for Android team labels May 3, 2023
@meteorcloudy meteorcloudy added team-Rules-Java Issues for Java rules and removed team-Android Issues for Android team labels May 3, 2023
@meteorcloudy
Copy link
Member

@comius Do you have any idea on this?

@fmeum
Copy link
Collaborator

fmeum commented May 3, 2023

Set.of isn't available in Java 8. It's possible that the Junit 4 runner isn't compatible with Java 8 anymore.

Edit: d6ad383 introduced this.

It would be really helpful to be able to test against Java 8 in regular Bazel tests.

@meteorcloudy
Copy link
Member

/cc @hvadehra

@meteorcloudy
Copy link
Member

https://buildkite.com/bazel/culprit-finder/builds/5466#0187e1f9-c27b-41bf-99fc-2863f41d6e7d points to 99846b0, which I guess update the default java_tools to the one containing the changes in d6ad383

@hvadehra hvadehra removed the untriaged label May 4, 2023
fweikert pushed a commit to fweikert/bazel that referenced this issue May 25, 2023
Removes usages of Set.of() that were introduced in javase9

Fixes bazelbuild#18300

Closes bazelbuild#18307.

PiperOrigin-RevId: 529369593
Change-Id: Id45afbb1bdee46910f4a9b632f479773c561c0a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants