Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ConfiguredTargetQuery to use KeyedConfiguredTarget as a value. #12547

Closed
wants to merge 4 commits into from
Closed

Change ConfiguredTargetQuery to use KeyedConfiguredTarget as a value. #12547

wants to merge 4 commits into from

Commits on Nov 25, 2020

  1. Change ConfiguredTargetQuery to use KeyedConfiguredTarget as a value. 

    This will allow us to keep the configured target key between lookup
rounds.

Fixes bazelbuild#11993.
    @katre
    katre committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    4ceaa1e View commit details
    Browse the repository at this point in the history

  2. Add check that correct type is always used.

    @katre
    katre committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    78892be View commit details
    Browse the repository at this point in the history

  3. Add a test for the missing toolchains case.

    @katre
    katre committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    22eec62 View commit details
    Browse the repository at this point in the history

  4. Add useful comment

    @katre
    katre committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    6db4c32 View commit details
    Browse the repository at this point in the history